Update FillTrigger.cxx#577
Conversation
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj#158 |
kjplows
left a comment
kjplows
left a comment
There was a problem hiding this comment.
there's an implicit cast here - see https://github.com/SBNSoftware/sbnanaobj/blob/develop/sbnanaobj/StandardRecord/SRTrigger.h#L16
Is this change necessary for CI?
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj#158 |
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj#158 |
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj#158 |
|
trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj#158 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
linyan-w
moved this from Reviewer Approved
to Waiting on Reviewer
in SBND 2025 Gen2 Production
nathanielerowe
moved this from Waiting on Reviewer
to Wait for next release (for data)
in SBND 2025 Gen2 Production
linyan-w
moved this from Wait for validation II
to Wait for next validation I patch (for MC)
in SBND 2025 Gen2 Production
linyan-w
moved this from Wait for next validation I patch (for MC)
to Wait for validation II
in SBND 2025 Gen2 Production
github-project-automation
Bot
moved this from To merge
to Done
in SBN software development
linyan-w
moved this from Wait for validation II
to In tagged release
in SBND 2025 Gen2 Production
4 participants
The CI was picking up some differences between trigger objects caused by recent SBND specific changes. This should resolve one of the issues.
Depends on: SBNSoftware/sbnanaobj#158